[v14] Add RunWhileLockedRetryInterval setting to TestAuthServer
#40221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the `RunWhileLockedRetryInterval` setting to TestAuthServer so we can disable retry waiting timeout when using fake clocks and `RunWhileLocked`. Signed-off-by: Tiago Silva <[email protected]>
tigrato
added
the
no-changelog
hugoShaka
approved these changes
Apr 4, 2024
…` for tests (#40083) * Add a way to configure the `RunWhileLocked.RunWhileLockedRetryInterval` for tests This PR adds a way to bypass the `cfg.Backend.Clock().After(cfg.RetryInterval)` call within `backend.AcquireLock` when using the fake clock. When multiple parallel calls try to acquire the same lock, `backend.AcquireLock` tries to sleep before retrying. When using the fake clock this operation isn't reliable enough when using `clock.Advance` so we are adding a way to configure it with negative values - i.e. retry immidately - for testing purposes. Signed-off-by: Tiago Silva <[email protected]> * update docs * drop testing.Testing usage --------- Signed-off-by: Tiago Silva <[email protected]>
marcoandredinis
approved these changes
Apr 10, 2024
public-teleport-github-review-bot
bot
removed the request for review
from jakule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40159 to branch/v14