Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AWS RDS db e2e tests #40065

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Conversation

GavinFrazar
Copy link
Contributor

This PR is only for e2e test code.
It was extracted out of a larger set of changes that add other DB types to the e2e tests.
I did some refactoring when I was adding the other db types, though they aren't in this PR to keep it smaller.

The main changes by this PR are:

  • update GHA workflow env vars to be RDS specific instead of generic.
    • I'm doing this so I can test minimal permission sets for each kind of aws database.
  • add auto db user provisioning tests
  • provision any db users needed in test code as setup, instead of relying on the cloud-terraform repo provisioning them
    • This simplifies test setup, and allows me to provision a db admin user with whatever permissions are needed easily.

* update GHA workflow env vars to be RDS specific
* add auto db user provisioning tests
* provision any db users needed in test code as setup, instead of
  relying on the cloud-terraform repo provisioning them
@GavinFrazar GavinFrazar added backport/branch/v13 backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 database-access Database access related issues and PRs labels Mar 30, 2024
@GavinFrazar GavinFrazar requested a review from greedy52 March 30, 2024 01:11
@GavinFrazar GavinFrazar marked this pull request as ready for review March 30, 2024 01:11
@github-actions github-actions bot requested a review from fspmarshall March 30, 2024 01:11
Copy link
Contributor

@greedy52 greedy52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks a lot for adding auto-user provisioning tests!

e2e/aws/rds_test.go Show resolved Hide resolved
e2e/aws/rds_test.go Outdated Show resolved Hide resolved
e2e/aws/rds_test.go Outdated Show resolved Hide resolved
e2e/aws/rds_test.go Outdated Show resolved Hide resolved
e2e/aws/rds_test.go Show resolved Hide resolved
e2e/aws/fixtures_test.go Outdated Show resolved Hide resolved
@greedy52 greedy52 self-requested a review April 1, 2024 14:44
@GavinFrazar GavinFrazar enabled auto-merge April 2, 2024 02:09
@GavinFrazar
Copy link
Contributor Author

needs codeowner reviewer to merge

Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot

@GavinFrazar GavinFrazar added this pull request to the merge queue Apr 2, 2024
Merged via the queue into master with commit 2ec63c8 Apr 2, 2024
36 checks passed
@GavinFrazar GavinFrazar deleted the gavinfrazar/update-rds-e2e-tests branch April 2, 2024 18:14
@public-teleport-github-review-bot

@GavinFrazar See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed
branch/v15 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v14 backport/branch/v15 database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants