-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GenerateUserCerts
to create App Sessions
#39970
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
f29af5d
to
ed8189a
Compare
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ed8189a
to
a50d782
Compare
96809c9
to
cd7c33f
Compare
a50d782
to
59e5e9c
Compare
cd7c33f
to
fcd67c8
Compare
59e5e9c
to
e9da3de
Compare
fcd67c8
to
7b63d01
Compare
15cc1f9
to
db5611b
Compare
7b63d01
to
83a8afb
Compare
d74c3b9
to
93b7f22
Compare
44d68fa
to
2c40e72
Compare
@zmb3 @strideynet friendly ping to review |
2c40e72
to
834a32e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies - got through most of reviewing this and forgot to finish my review. Looks glad - I'm glad this is a single RPC now.
This reverts commit cc6caa2.
Implement the changes to
GenerateUserCerts
described in RFD 169Backwards compatibility between v16 clients and v15 auth servers is handled through a best-effort version check to determine whether the client should create an app session separately. This replaces one roundtrip with another (Ping) but can be removed in v17.
Based off #39742