Introduce plugin cleanup endpoints. #39957
Conversation
Plugin cleanup endpoints have been introduced. One that indicates whether a plugin needs cleanup, the other that actually performs cleanup. This is primarily to address issues with the Okta integration and leftover assignments.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
Can you share a bit more context about what these RPCs are going to be used for? |
Basically, the Okta access list sync can operate on leftover assignments if you delete and re-create the plugin. For example, it may find an old access list, remove it since it no longer matches the filters, and then clean up the relevant assignments. In order to get around it, we'll introduce this method to remove all the bits and pieces from the backend so that this doesn't happen. |
| message NeedsCleanupRequest { | ||
| // Type is the plugin type. We only need the string representation of the plugin type and not | ||
| // the PluginType message, as we don't want the oauth client ID here. | ||
| string type = 1; |
There was a problem hiding this comment.
should types like this be represented as an enum?
There was a problem hiding this comment.
Perhaps, but unfortunately I think that ship has sailed -- other instances where we've got a plugin type are represented as strings.
public-teleport-github-review-bot
bot
removed the request for review
from bl-nero
Plugin cleanup endpoints have been introduced. One that indicates whether a plugin needs cleanup, the other that actually performs cleanup. This is primarily to address issues with the Okta integration and leftover assignments.
changelog: Certain plugins are now able to be cleaned up before they're re-created after being deleted.