Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Set correct repo version based on Cloud automatic upgrader output #39910

Closed
wants to merge 1 commit into from

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Mar 27, 2024

This PR fixes the manual package repo installation instructions for Teleport Cloud.

Currently, following the instructions in the doc results in the following line being written to the teleport.list file:

deb [signed-by=/usr/share/keyrings/teleport-archive-keyring.asc] https://apt.releases.teleport.dev/ubuntu jammy stable/14.3.7

This is incorrect for two reasons:

  • no v before the version
  • outputs the full version rather than major version

Package manager commands fail as a result.

After this PR, the line is written correctly:

deb [signed-by=/usr/share/keyrings/teleport-archive-keyring.asc] https://apt.releases.teleport.dev/ubuntu jammy stable/v14

It also adds a missing trailing " to the end of a couple of commands.

All other changes are my editor automatically trimming excess whitespace.

@webvictim webvictim added documentation no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels Mar 27, 2024
@webvictim webvictim requested review from bernardjkim and ptgott March 27, 2024 18:11
@webvictim webvictim self-assigned this Mar 27, 2024
@webvictim webvictim enabled auto-merge March 27, 2024 18:11
@webvictim webvictim requested review from zmb3 and r0mant March 27, 2024 18:11
@github-actions github-actions bot requested a review from xinding33 March 27, 2024 18:11
Copy link

🤖 Vercel preview here: https://docs-qo7o7ll2y-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-44slefsr3-goteleport.vercel.app/docs/ver/preview

@webvictim webvictim force-pushed the gus/docs/cloud-installation-version branch from cbc0a54 to d835781 Compare March 27, 2024 18:32
Copy link

🤖 Vercel preview here: https://docs-esbr5x4ix-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-5ho0yg285-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-gz7rc5wko-goteleport.vercel.app/docs/ver/preview

@bernardjkim
Copy link
Contributor

I think this is the same fix being addressed in #39508

@webvictim
Copy link
Contributor Author

Thanks - closing in favour of #39508

@webvictim webvictim closed this Mar 28, 2024
auto-merge was automatically disabled March 28, 2024 10:58

Pull request was closed

@webvictim webvictim deleted the gus/docs/cloud-installation-version branch March 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants