Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Add sortable notification cache variants #39893

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Mar 27, 2024

backport #39616 to branch/v15

Mostly clean backport, only change was adding this CheckAndSetDefaults check in newResourceWatcher, which is in master:

func newResourceWatcher(ctx context.Context, collector resourceCollector, cfg ResourceWatcherConfig) (*resourceWatcher, error) {
if err := cfg.CheckAndSetDefaults(); err != nil {
return nil, trace.Wrap(err)
}

@rudream rudream added the no-changelog Indicates that a PR does not require a changelog entry label Mar 27, 2024
@rudream rudream added this pull request to the merge queue Mar 28, 2024
Merged via the queue into branch/v15 with commit 5a02746 Mar 28, 2024
37 of 38 checks passed
@rudream rudream deleted the yassine/v15/notifications/sortcache branch March 28, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants