Fix issues with User Sync audit events #39830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UserSync Events have fields whose values are routinely 0, which the JSON marshaler was omitting. This patch removes the `omitempty` directive so these values are preserved in the serialized event. - Typo in the UserSync event failure code
tcsc
added
backport/branch/v14
no-changelog
github-actions
bot
added
audit-log
mdwn
approved these changes
Mar 26, 2024
zmb3
approved these changes
Mar 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON marshaler was omitting. This patch removes the
omitemptydirective so these values are preserved in the serialized event.