Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation from tshd/types.ts to proto files #39827

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Mar 26, 2024

The custom types will be removed in the next PR.
To preserve them, this PR moves JSDoc comments from tshd/types.ts to the relevant .proto files.

@gzdunek gzdunek added teleport-connect Issues related to Teleport Connect. no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels Mar 26, 2024
@gzdunek gzdunek requested review from ravicious and avatus March 26, 2024 12:38
@github-actions github-actions bot requested review from kimlisa and rudream March 26, 2024 12:38
@gzdunek gzdunek removed request for kimlisa and rudream March 26, 2024 12:39
proto/teleport/lib/teleterm/v1/cluster.proto Outdated Show resolved Hide resolved
proto/teleport/lib/teleterm/v1/cluster.proto Outdated Show resolved Hide resolved
@gzdunek gzdunek added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit 62caebb Mar 29, 2024
40 checks passed
@gzdunek gzdunek deleted the gzdunek/move-proto-comments branch March 29, 2024 09:04
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/sm teleport-connect Issues related to Teleport Connect. ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants