[v14] add kubernetes waiting container backend service and API #39817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add kubernetes waiting container backend service and API * remove other resource type * add unit test * fix after rebasing * address feedback * remove KubeWaitingContainerRequest * check for nil in validation func * remove UnwrapResource153 * fix test * address feedback * address linter issues * fix cache watch kind test
This PR adds the `patch_type` to `KubernetesWaitingContainer` objects. This patch type is used to decode the contents correctly depending on different patch strategies allowed by Kubernetes clients. Signed-off-by: Tiago Silva <[email protected]>
This PR fixes an error thrown by `kubewaitingcontainer.NewKubeWaitingContainer` because `kubewaitingcontainerpb.KubernetesWaitingContainerSpec` missed the `Patch` and `PatchType` fields when propgating delete events through cache. Signed-off-by: Tiago Silva <[email protected]>
capnspacehook
added
the
no-changelog
tigrato
approved these changes
Mar 26, 2024
rosstimothy
approved these changes
Mar 26, 2024
capnspacehook
deleted the
capnspacehook/backport/v14/kube-waiting-cont-backend
branch
|
Friendly ping @rosstimothy |
|
Oops the page hadn't updated before I sent that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of:
patch_typetoKubernetesWaitingContainer#39738