[v14] always require MFA when joining a session if at least one role requires session MFA #39815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es session MFA * extend role 'join_sessions' so MFA can be required at the role level when joining sessions * add test cases * update operator CRDs * remove change to 'join_sessions', instead require MFA if any roles require it * add comment * address feedback * add additional test cases * add authhandler test * fix role from test case not getting used in test
codingllama
reviewed
Mar 26, 2024
|
Yep missed that the second test was failing to build, should be fixed now |
codingllama
approved these changes
Mar 26, 2024
rosstimothy
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39602.
Note that the unit test had to be reworked a bit to call
IsMFARequiredinstead ofCreateAuthenticateChallenge, because in v14CreateAuthenticateChallengeRequestdoesn't have aMFARequiredCheckfield.changelog: fix MFA checks not being prompted when joining a session