Teleterm: Define access request fields necessary for selecting time options

[kimlisa]

part of #35436

I also sneaked in an export RadioGroup.tsx required in an enterprise work

[github-actions]

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

[kimlisa]

@gzdunek @ravicious , just FYI, this PR adds more fields than just assume_start_time, the other fields are required for calculating/rendering time options for users (like in the web UI)

[ravicious]

Submitted some nits, looks good overall.

[kimlisa]

@ravicious @gzdunek can i get a sanity check for this commit and this follow up enterprise PR

[ravicious]

req can be dropped completely and we can pass params directly:

diff --git a/web/packages/teleterm/src/services/tshd/createClient.ts b/web/packages/teleterm/src/services/tshd/createClient.ts
index 6aa17d551b..c99a1b67b6 100644
--- a/web/packages/teleterm/src/services/tshd/createClient.ts
+++ b/web/packages/teleterm/src/services/tshd/createClient.ts
@@ -295,19 +295,8 @@ export function createTshdClient(
     },
 
     async createAccessRequest(params: types.CreateAccessRequestParams) {
-      const req = api.CreateAccessRequestRequest.create({
-        rootClusterUri: params.rootClusterUri,
-        suggestedReviewers: params.suggestedReviewers,
-        roles: params.roles,
-        reason: params.reason,
-        dryRun: params.dryRun,
-        maxDuration: params.maxDuration,
-        requestTtl: params.requestTtl,
-        assumeStartTime: params.assumeStartTime,
-        resourceIds: params.resourceIds,
-      });
       return new Promise<AccessRequest>((resolve, reject) => {
-        tshd.createAccessRequest(req, (err, response) => {
+        tshd.createAccessRequest(params, (err, response) => {
           if (err) {
             reject(err);
           } else {

[ravicious]

The changes from this PR seem okay and they typecheck. I'm able to successfully submit an access request, but when I then go to list all requests in Connect, I see "Invalid time value".

I added a console.error to see the exact error:

diff --git a/web/teleterm/src/ui/DocumentAccessRequests/useAccessRequests.tsx b/web/teleterm/src/ui/DocumentAccessRequests/useAccessRequests.tsx
index 216dae57..d03f6e36 100644
--- a/web/teleterm/src/ui/DocumentAccessRequests/useAccessRequests.tsx
+++ b/web/teleterm/src/ui/DocumentAccessRequests/useAccessRequests.tsx
@@ -57,6 +57,7 @@ export default function useAccessRequests(doc: types.DocumentAccessRequests) {
       );
       setAccessRequests(requests);
     } catch (err) {
+      console.log(err);
       setAttempt({
         status: 'failed',
         statusText: err.message,

And the error is:

RangeError: Invalid time value
    at formatDistanceStrict (date-fns.js?v=1abd8bfc:2759:11)
    at getDurationText (makeAccessRequest.ts:87:20)
    at makeAccessRequest (makeAccessRequest.ts:24:22)
    at makeUiAccessRequest (useAccessRequests.tsx:98:10)
    at useAccessRequests.tsx:56:17
    at Array.map (<anonymous>)
    at getRequests (useAccessRequests.tsx:55:33)

It looks like makeAccessRequest from e/web/teleport/src/services/workflow/makeAccessRequest.ts expects dates to be Date instances. The argument to it doesn't have a type, so we didn't get type errors for that.

Perhaps makeUiAccessRequest from e/web/teleterm/src/ui/DocumentAccessRequests/useAccessRequests.tsx needs to be updated?

[kimlisa]

thanks so much for catching these, i updated the types here and added a test to hopefully catch them easier in future. probably the best way to prevent is to type the response value right? but i think that's going to create more refactoring

i also ran teleterm to test these changes out

[gzdunek]

Yeah, in teleterm we shouldn't use makeAccessRequest from web as it converts the fully typed response to any :(
But this is out of scope for this PR.

[public-teleport-github-review-bot]

@kimlisa See the table below for backport results.

Branch	Result
branch/v14	Failed
branch/v15	Failed