TAG: Poll AWS EKS clusters fom AWS #38984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
the
no-changelog
tigrato
force-pushed
the
tigrato/poll-aws-eks-clusters
branch
3 times, most recently
from
228d360 to
20aa730
Compare
jakule
approved these changes
Mar 6, 2024
rosstimothy
reviewed
Mar 6, 2024
Comment on lines
73
to
80
| if err != nil { | ||
| errs = append(errs, err) | ||
| } | ||
| if cluster != nil { | ||
| clusters = append(clusters, cluster) | ||
| } | ||
| associatedPolicies = append(associatedPolicies, clusterAssociatedPolicies...) | ||
| accessEntries = append(accessEntries, clusterAccessEntries...) |
There was a problem hiding this comment.
In what cases do we expect both an error and the rest of the arguments to be non-nil?
There was a problem hiding this comment.
We pull each region independently and each one shouldn't affect the other - i.e. we might miss permissions to a specific region or the api calls fails and in that case we should continue with other regions that are alive and working
Added in 4b2a6cd |
justinas
approved these changes
Mar 7, 2024
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
tigrato
force-pushed
the
tigrato/poll-aws-eks-clusters
branch
from
91324c3 to
f1c942e
Compare
This PR polls the AWS EKS clusters and their AssociatedAccessPolicies and AccessEntries and syncs them into TAG. Part of gravitational/access-graph#459 Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/poll-aws-eks-clusters
branch
from
f1c942e to
b1a143d
Compare
tigrato
added a commit
that referenced
this pull request
Mar 12, 2024
This PR polls the AWS EKS clusters and their AssociatedAccessPolicies and AccessEntries and syncs them into TAG. Part of gravitational/access-graph#459 Signed-off-by: Tiago Silva <[email protected]>
tigrato
added a commit
that referenced
this pull request
Mar 12, 2024
This PR polls the AWS EKS clusters and their AssociatedAccessPolicies and AccessEntries and syncs them into TAG. Part of gravitational/access-graph#459 Signed-off-by: Tiago Silva <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
This PR polls the AWS EKS clusters and their AssociatedAccessPolicies and AccessEntries and syncs them into TAG. Part of gravitational/access-graph#459 Signed-off-by: Tiago Silva <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
This PR polls the AWS EKS clusters and their AssociatedAccessPolicies and AccessEntries and syncs them into TAG. Part of gravitational/access-graph#459 Signed-off-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polls the AWS EKS clusters and their AssociatedAccessPolicies and AccessEntries and syncs them into TAG.
Part of https://github.com/gravitational/access-graph/issues/459