[v15] Attempt to make TestClient_DialHost more reliable #38882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes inspiration from gravitational/teleport.e#1944 which addressed similar EOF error showing up when driving streams in tests. From https://pkg.go.dev/google.golang.org/grpc#ClientStream.SendMsg: > // SendMsg is generally called by generated code. On error, SendMsg aborts > // the stream. If the error was generated by the client, the status is > // returned directly; otherwise, io.EOF is returned and the status of > // the stream may be discovered using RecvMsg.
rosstimothy
added
the
no-changelog
espadolini
approved these changes
Mar 5, 2024
zmb3
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #38856 to branch/v15