[v15] Copy expression package out of /e #38707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardDowling
added
the
no-changelog
codingllama
approved these changes
Feb 28, 2024
|
@nklaassen could you have a look at this when you get a sec |
r0mant
previously requested changes
Mar 15, 2024
There was a problem hiding this comment.
Before we merge this backport, it looks like the corresponding change that removes the moved code from teleport.e still hasn't been merged to master: https://github.com/gravitational/teleport.e/pull/3531.
Please fully wrap up the change in master and merge teleport.e side before starting to backport, and then backport both parts in tandem so we don't end up with code duplication.
r0mant
approved these changes
Mar 21, 2024
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
EdwardDowling
dismissed
r0mant’s stale review
Expression package has been removed from /e in https://github.com/gravitational/teleport.e/pull/3531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #38576 to branch/v15