-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Set resource request/limit on wait-auth-update initContainer #38672
Merged
webvictim
merged 2 commits into
master
from
gus/helm/add-resources-to-default-initcontainer
Feb 27, 2024
Merged
helm: Set resource request/limit on wait-auth-update initContainer #38672
webvictim
merged 2 commits into
master
from
gus/helm/add-resources-to-default-initcontainer
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
added
helm
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
labels
Feb 27, 2024
webvictim
removed
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Feb 27, 2024
tigrato
previously approved these changes
Feb 27, 2024
tigrato
dismissed
their stale review
February 27, 2024 14:59
I didn't realize that we were reusing the same resources as the proxy itself
tigrato
reviewed
Feb 27, 2024
examples/chart/teleport-cluster/templates/proxy/deployment.yaml
Outdated
Show resolved
Hide resolved
hugoShaka
approved these changes
Feb 27, 2024
webvictim
changed the title
helm: Propagate resources to wait-auth-update initContainer
helm: Set resource request/limit on wait-auth-update initContainer
Feb 27, 2024
tigrato
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely
public-teleport-github-review-bot
bot
removed request for
klizhentas and
r0mant
February 27, 2024 18:33
webvictim
deleted the
gus/helm/add-resources-to-default-initcontainer
branch
February 27, 2024 18:51
@webvictim See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37476
changelog: Resource limits are now correctly applied to the
wait-auth-update
initContainer in theteleport-cluster
Helm chart.