-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump k8s modules #38625
Merged
Merged
chore: Bump k8s modules #38625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Feb 26, 2024
Branched from #38624. |
rosstimothy
approved these changes
Feb 26, 2024
greedy52
approved these changes
Feb 26, 2024
codingllama
force-pushed
the
codingllama/bump-otel
branch
from
February 26, 2024 15:10
4065c86
to
3bc239f
Compare
codingllama
force-pushed
the
codingllama/bump-k8s
branch
from
February 26, 2024 15:11
ec06229
to
81a7407
Compare
codingllama
force-pushed
the
codingllama/bump-k8s
branch
from
February 26, 2024 17:13
81a7407
to
d94b9b3
Compare
Hrmm there seems to be a breakage introduced here
|
Yep, I'm trying to figure out what's up. |
$ make enter
$ C_INCLUDE_PATH=/usr/libbpf-1.2.2/include go test -tags=bpf ./lib/bpf/... -v
# github.com/prometheus/client_golang/prometheus/testutil/promlint
/tmp/gomodcache/github.com/prometheus/[email protected]/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.FmtText
FAIL github.com/gravitational/teleport/lib/bpf [build failed]
FAIL |
codingllama
force-pushed
the
codingllama/bump-k8s
branch
from
February 26, 2024 18:32
f3f1c84
to
5a8d4ca
Compare
codingllama
commented
Feb 26, 2024
@@ -149,7 +149,7 @@ require ( | |||
github.com/pquerna/otp v1.4.0 | |||
github.com/prometheus/client_golang v1.18.0 | |||
github.com/prometheus/client_model v0.5.0 | |||
github.com/prometheus/common v0.46.0 | |||
github.com/prometheus/common v0.45.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches prometheus/client_golang v1.18.0: https://github.com/prometheus/client_golang/blob/v1.18.0/go.mod#L10-L12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update k8s modules to their latest versions.
Split from #38605.