Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove otel from dependabot ignore list #38622

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

rosstimothy
Copy link
Contributor

The latest version of otel has fixed the data races that were preventing us from upgrading. Removing the dependencies from the ignore list so that dependabot can update them.

Changelog

Sourced from go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's changelog.

[1.24.0/0.49.0/0.18.0/0.4.0] - 2024-02-23

This release is the last to support [Go 1.20]. The next release will require at least [Go 1.21].

Added

  • Support [Go 1.22]. (#5082)
  • Add support for Summary metrics to go.opentelemetry.io/contrib/bridges/prometheus. (#5089)
  • Add support for Exponential (native) Histograms in go.opentelemetry.io/contrib/bridges/prometheus. (#5093)

Removed

  • The deprecated RequestCount constant in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp is removed. (#4894)
  • The deprecated RequestContentLength constant in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp is removed. (#4894)
  • The deprecated ResponseContentLength constant in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp is removed. (#4894)
  • The deprecated ServerLatency constant in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp is removed. (#4894)

Fixed

  • Retrieving the body bytes count in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp does not cause a data race anymore. (#5080)

The latest version of otel has fixed the data races that were
preventing us from upgrading. Removing the dependencies from the
ignore list so that dependabot can update them.
@github-actions github-actions bot requested a review from bl-nero February 26, 2024 13:58
@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Feb 26, 2024
@gravitational gravitational deleted a comment from github-actions bot Feb 26, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from bl-nero February 26, 2024 15:19
@rosstimothy rosstimothy added this pull request to the merge queue Feb 26, 2024
@codingllama
Copy link
Contributor

Maybe hold this in favor of #38636 ?

@rosstimothy
Copy link
Contributor Author

#38636 can safely be applied after this change though right?

Merged via the queue into master with commit 0c9d397 Feb 26, 2024
36 of 37 checks passed
@rosstimothy rosstimothy deleted the tross/allow_otel_updates branch February 26, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants