Add SessionRecordingConfig support to cluster configuration RPC service #38591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/cluster_config_rpc_networking
branch
2 times, most recently
from
de2cffc to
4388695
Compare
rosstimothy
force-pushed
the
tross/cluster_config_rpc_recording
branch
2 times, most recently
from
a0d615d to
d15be58
Compare
rosstimothy
force-pushed
the
tross/cluster_config_rpc_networking
branch
from
4388695 to
898b050
Compare
rosstimothy
force-pushed
the
tross/cluster_config_rpc_recording
branch
from
d15be58 to
fd3d649
Compare
espadolini
reviewed
Feb 26, 2024
rosstimothy
force-pushed
the
tross/cluster_config_rpc_networking
branch
from
898b050 to
3a376d9
Compare
rosstimothy
force-pushed
the
tross/cluster_config_rpc_recording
branch
from
3c9b2a1 to
1c03b29
Compare
espadolini
approved these changes
Feb 27, 2024
rosstimothy
force-pushed
the
tross/cluster_config_rpc_networking
branch
2 times, most recently
from
87b2d6c to
0ce12e2
Compare
Base automatically changed from
tross/cluster_config_rpc_networking
to
master
February 27, 2024 22:47
rosstimothy
force-pushed
the
tross/cluster_config_rpc_recording
branch
from
1c03b29 to
483873a
Compare
rosstimothy
force-pushed
the
tross/cluster_config_rpc_recording
branch
from
483873a to
9b73a63
Compare
|
PTAL @GavinFrazar |
GavinFrazar
approved these changes
Feb 27, 2024
Sorry about that. This was the last of a series of three PRs and there were some additional commits that popped in as I was trying to rebase after the previous two were merged. |
Extends the clusterconfigv1.Service to implement RPCs for interacting with SessionRecordingConfig. The various GetSessionRecordingConfig interfaces were also all updated to remove the marshal options since they were never used and served no purpose.
rosstimothy
force-pushed
the
tross/cluster_config_rpc_recording
branch
from
629de3b to
f162221
Compare
rosstimothy
added a commit
that referenced
this pull request
Mar 15, 2024
…ce (#38591) * Remove marshal options from GetSessionRecordingConfig * Add SessionRecordingConfig support to cluster configuration RPC service Extends the clusterconfigv1.Service to implement RPCs for interacting with SessionRecordingConfig. The various GetSessionRecordingConfig interfaces were also all updated to remove the marshal options since they were never used and served no purpose.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Update cluster configuration backend service APIs (#38349) Extends the storage layer of ClusterAuthPreference, ClusterNetworkingConfig, ClusterAuditConfig, and SessionRecordingConfig to support Create, Update and Upsert. This will allow consumers of this layer to chose the appropriate write operation instead of only having a single Set operation. * Add the cluster configuration RPC service (#38523) The new clusterconfigv1.Service implements the gRPC service defined in teleport.clusterconfig.v1.ClusterConfigService. The initial implementation is restricted to supporting cluster auth preferences. Support for remaining cluster configuration resources will come in a series of future PRs. Once all of the resources are covered the service will be added to the Auth server and consumers of the old API will be migrated. * Add ClusterNetworkingConfig support to cluster configuration RPC service (#38590) * Remove marshal options from GetClusterNetworkingConfig * Add ClusterNetworkingConfig support to cluster configuration RPC service Extends the clusterconfigv1.Service to implement RPCs for interacting with ClusterNetworkingConfig. The various GetClusterNetworkingConfig interfaces were also all updated to remove the marshal options since they were never used and served no purpose. * Add SessionRecordingConfig support to cluster configuration RPC service (#38591) * Remove marshal options from GetSessionRecordingConfig * Add SessionRecordingConfig support to cluster configuration RPC service Extends the clusterconfigv1.Service to implement RPCs for interacting with SessionRecordingConfig. The various GetSessionRecordingConfig interfaces were also all updated to remove the marshal options since they were never used and served no purpose. * fix: update call using marshal options * propagate revisions during upsert for cache * register rpc service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the clusterconfigv1.Service to implement RPCs for interacting with SessionRecordingConfig. The various GetSessionRecordingConfig interfaces were also all updated to remove the marshal options since they were never used and served no purpose.