Augment unified resource requests with login information #38559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/include_logins
branch
from
03a9c5a to
467e6c9
Compare
nklaassen
reviewed
Feb 22, 2024
rosstimothy
force-pushed
the
tross/include_logins
branch
2 times, most recently
from
12d094a to
f6c3caa
Compare
rosstimothy
force-pushed
the
tross/include_logins
branch
from
f6c3caa to
3a3af89
Compare
nklaassen
reviewed
Feb 27, 2024
nklaassen
reviewed
Feb 29, 2024
rosstimothy
force-pushed
the
tross/include_logins
branch
4 times, most recently
from
737c573 to
aa196ba
Compare
rosstimothy
force-pushed
the
tross/include_logins
branch
from
aa196ba to
e90f9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new IncludeLogin flag to unified resource requests to indicate that unified resource responses should include both the resource and the allowed logins the user has per resource. The Web UI was updated to add this flag when listing resources in leaf clusters so that the login dropdown can be correctly populated. Instead of showing all logins, the Web UI will only show the subset of allowed logins for the resource as reported by the leaf, and the logins that exist in the user certificates held by the Proxy. This is required because user certificates are only generated for the root cluster, and if we were to allow all logins as reported by the leaf a user would be denied access because the login they are attempting to use would not be in the list of valid principals.