[wip] pagination & sorting for access requests #38516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
force-pushed
the
fspmarshall/sort-cache
branch
from
2c3a246 to
c29dd60
Compare
|
Closing in favor of #38633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pagination and custom sort indexes for access requests. Custom sort orders are implemented via a custom cache implementation built on the sortcache from #38391 and heavily inspired by the existing unified resource cache.
Most of the interesting stuff lives in
services/access_request_cache.go.Note: in draft to get some early feedback on a few specific pieces. Still in need of some polish and additional manual testing.