[v14] Perform server version validation before using clients #38465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agents performed the following steps when creating an auth client: 1) Create an auth gRPC client 2) Call proto.AuthService/GetDomainName to force gRPC to dial the auth server in order to validate the connection since gRPC only dials on the first RPC 3) Call proto.AuthService/GetCertAuthority to get the HostCA 4) Call proto.AuthService/Ping to get the server version to determine if the connection should be aborted unless --skip-version-check was provided On the surface this seems fine, however, the skip version check did not happen until after two RPCs to auth had already been issued. If either of those RPCs has changed the agent could perpetually fail to connect to the cluster even though it should have never tried due to version differences. The order of the steps was changed to the following such that the version check happens first. 1) Create an auth gRPC client 2) Call proto.AuthService/Ping to force gRPC to dial AND to get the server version information 3) Run the server version check and abort unless --skip-version-check was provided 4) Call proto.AuthService/GetCertAuthority to get the HostCA An added benefit to this is agents now require one less RPC when joining.
rosstimothy
added
backport
no-changelog
AntonAM
approved these changes
Feb 20, 2024
espadolini
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #38016 to branch/v14