-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Avoid tsh panic on Windows Server 2019 #38444
Conversation
FYI @stevenGravy. |
thanks! @tenaciousdlg |
Steven kindly tried out a test build, seems to be working fine. |
@codingllama See the table below for backport results.
|
I have the same issue with tsh v.14.3.3 and 15.0.2.
|
@sergefedorow Could you try tsh v14.3.4 which shipped with this fixed? 15.0.3 is not out yet but it'll include the fix as well. |
@ravicious Unfortunately 14.3.4 does not work for me either. |
Sorry, my bad, I looked at the release notes for 14.3.4 and I saw #36868 which was a fix for a similar problem. 14.3.7+ is going to include the fix, I imagine it'll be released later this or next week. |
Some Windows installs appear to contain a WebAuthn.dll without WebAuthNGetApiVersionNumber, which leads to a panic. This PR aims to fix that.
Error on Windows Server 2019
WebAuthNGetApiVersionNumber is a v1 procedure on WebAuthn.dll, so in its absence we disable WebAuthn support as well (as all bets are off in which other functions may or may not exist).
Changelog: Avoid tsh/WebAuthn.dll panic on Windows Server 2019