Postgres: fix corner case of NULL/empty arrays comparison for roles #38429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
database-access
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
greedy52
approved these changes
Feb 20, 2024
camscale
approved these changes
Feb 20, 2024
smallinsky
approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Tener
force-pushed
the
tener/postgres-no-roles-null-array
branch
from
fa80528 to
cdeda4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With automatic user provisioning enabled, when the user initiates a second connection to the database, we verify that their roles hasn't changed. If the current or upcoming set of roles are empty, the check returns incorrect results. This PR fixes the check by making sure we are working with empty arrays instead of NULLs, and checking the length of array using
cardinalitywhich returns0for empty arrays.Changelog: Fixed Postgres issue preventing multiple connections for auto-provisioned users with no database roles.