Fix host user creation mode docs #38366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atburke
added
no-changelog
github-actions
bot
requested review from
Joerger,
ptgott,
r0mant,
rosstimothy,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-kulwxzo2z-goteleport.vercel.app/docs/ver/preview |
rosstimothy
reviewed
Feb 20, 2024
Comment on lines
30
to
35
|
|
||
| First, create a role with `create_host_user_mode` set to `drop`, `insecure-drop`, or `keep`. | ||
| First, create a role with `create_host_user_mode` set to `keep` or `insecure-drop`. | ||
|
|
||
| - `keep` will create permanent users on the host at login time. This is the | ||
| recommended host user creation mode. | ||
| - `insecure-drop` will create transient users that are deleted once the session ends. |
There was a problem hiding this comment.
Should we even present the option of insecure-drop if we want keep to be the default option for 99% of use cases?
There was a problem hiding this comment.
Maybe not, although a reader might be confused as to why create_host_user_mode exists but can only take one value.
ptgott
approved these changes
Feb 20, 2024
|
🤖 Vercel preview here: https://docs-bzwx8hr9n-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-ewgcurdmm-goteleport.vercel.app/docs/ver/preview |
rosstimothy
approved these changes
Feb 23, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
zmb3,
Joerger and
xinding33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a few issues in the host user creation mode docs:
dropmodekeepmode