-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize two Access Controls sections #38094
Conversation
🤖 Vercel preview here: https://docs-h6axa1pjs-goteleport.vercel.app/docs/ver/preview |
|
||
### Start minikube | ||
|
||
Start minikube with the Docker driver: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment saying this step isn't required if you already have a kubernetes cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this guide assumes that the user is using minikube (e.g., the example roles). Reworking the guide will change the scope of this PR beyond just moving the guide to a new location. Would it make sense to address this feedback in a future change?
968ba81
to
25cf715
Compare
🤖 Vercel preview here: https://docs-1ph0oksgr-goteleport.vercel.app/docs/ver/preview |
25cf715
to
be750a7
Compare
🤖 Vercel preview here: https://docs-o3s9mqgea-goteleport.vercel.app/docs/ver/preview |
be750a7
to
5bfd4c0
Compare
🤖 Vercel preview here: https://docs-62f40nq9s-goteleport.vercel.app/docs/ver/preview |
Partially addresses #37558 - Remove the Kubernetes Federation guide. This is more of a side note about `tsh login` with trusted clusters, and gets very little traffic. Consolidate it with the trusted cluster guide, which is more popular. This allows us to remove the "Manage Access" subsection of "Kubernetes Access", which only contains this and the RBAC how-to guide. - Collapse the Kubernetes RBAC how-to guide into "Manage Access" to make it more discoverable. - Collapse the "Configuring Access" guide for databases into "RBAC". The section contains a single guide, so this makes the content more discoverable.
- Add `tsh kube login` instructions to the trusted cluster guide changes.
5bfd4c0
to
2322d7a
Compare
🤖 Vercel preview here: https://docs-j5l4bhxu5-goteleport.vercel.app/docs/ver/preview |
Partially addresses #37558
Remove the Kubernetes Federation guide. This is more of a side note about
tsh login
with trusted clusters, and gets very little traffic. Consolidate it with the trusted cluster guide, which is more popular. This allows us to remove the "Manage Access" subsection of "Kubernetes Access", which only contains this and the RBAC how-to guide.Collapse the Kubernetes RBAC how-to guide into "Manage Access" to make it more discoverable.
Collapse the "Configuring Access" guide for databases into "RBAC". The section contains a single guide, so this makes the content more discoverable.