Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize two Access Controls sections #38094

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Feb 12, 2024

Partially addresses #37558

  • Remove the Kubernetes Federation guide. This is more of a side note about tsh login with trusted clusters, and gets very little traffic. Consolidate it with the trusted cluster guide, which is more popular. This allows us to remove the "Manage Access" subsection of "Kubernetes Access", which only contains this and the RBAC how-to guide.

  • Collapse the Kubernetes RBAC how-to guide into "Manage Access" to make it more discoverable.

  • Collapse the "Configuring Access" guide for databases into "RBAC". The section contains a single guide, so this makes the content more discoverable.

Copy link

🤖 Vercel preview here: https://docs-h6axa1pjs-goteleport.vercel.app/docs/ver/preview

docs/pages/management/admin/trustedclusters.mdx Outdated Show resolved Hide resolved

### Start minikube

Start minikube with the Docker driver:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment saying this step isn't required if you already have a kubernetes cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this guide assumes that the user is using minikube (e.g., the example roles). Reworking the guide will change the scope of this PR beyond just moving the guide to a new location. Would it make sense to address this feedback in a future change?

@ptgott ptgott force-pushed the paul.gottschling/37558-controls branch from 968ba81 to 25cf715 Compare February 26, 2024 14:53
@ptgott ptgott requested a review from tigrato February 26, 2024 14:53
Copy link

🤖 Vercel preview here: https://docs-1ph0oksgr-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/37558-controls branch from 25cf715 to be750a7 Compare March 1, 2024 16:57
Copy link

github-actions bot commented Mar 1, 2024

🤖 Vercel preview here: https://docs-o3s9mqgea-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/37558-controls branch from be750a7 to 5bfd4c0 Compare March 5, 2024 15:29
Copy link

github-actions bot commented Mar 5, 2024

🤖 Vercel preview here: https://docs-62f40nq9s-goteleport.vercel.app/docs/ver/preview

ptgott added 3 commits March 6, 2024 14:37
Partially addresses #37558

- Remove the Kubernetes Federation guide. This is more of a side note
  about `tsh login` with trusted clusters, and gets very little traffic.
  Consolidate it with the trusted cluster guide, which is more popular.
  This allows us to remove the "Manage Access" subsection of "Kubernetes
  Access", which only contains this and the RBAC how-to guide.

- Collapse the Kubernetes RBAC how-to guide into "Manage Access" to make
  it more discoverable.

- Collapse the "Configuring Access" guide for databases into "RBAC". The
  section contains a single guide, so this makes the content more
  discoverable.
- Add `tsh kube login` instructions to the trusted cluster guide
  changes.
@ptgott ptgott force-pushed the paul.gottschling/37558-controls branch from 5bfd4c0 to 2322d7a Compare March 6, 2024 19:38
Copy link

github-actions bot commented Mar 6, 2024

🤖 Vercel preview here: https://docs-j5l4bhxu5-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott added this pull request to the merge queue Mar 12, 2024
Merged via the queue into master with commit 5daa164 Mar 12, 2024
36 checks passed
@ptgott ptgott deleted the paul.gottschling/37558-controls branch March 12, 2024 18:53
@public-teleport-github-review-bot

@ptgott See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants