Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cockroachdb storage backend configuration #37880

Merged
merged 13 commits into from
Mar 10, 2024
Merged

Conversation

dboslee
Copy link
Contributor

@dboslee dboslee commented Feb 7, 2024

Adds documentation for configuring cockroachdb as a storage backend.

This is the first enterprise only backend so I'm not certain what is the best way to indicate this is enterprise only.

Copy link

github-actions bot commented Feb 7, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

github-actions bot commented Feb 7, 2024

🤖 Vercel preview here: https://docs-95kreh57y-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Feb 7, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
Copy link

github-actions bot commented Feb 7, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

github-actions bot commented Feb 7, 2024

🤖 Vercel preview here: https://docs-c4v7480hw-goteleport.vercel.app/docs/ver/preview

docs/pages/reference/backends.mdx Outdated Show resolved Hide resolved

For more details on deploying CockroachDB see [CockroachDB's deployment options](https://www.cockroachlabs.com/docs/stable/choose-a-deployment-option).

For more details on configuring multi-region survival goals in CockroachDB see
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For more details" suggests that there are at least some details here, but I don't see anything about configuring multi-region survival goals.

I would rephrase this. Perhaps something along the lines of this:

There are several ways to configure multi-region deployments of CockroachDB,
the details of which are not in scope for this guide. To learn about how to
configure multi-region survival goals, see ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense I updated this for both the deployment and survival goals here b42399a

Copy link

github-actions bot commented Feb 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

github-actions bot commented Feb 9, 2024

🤖 Vercel preview here: https://docs-a7qfq88sb-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Feb 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@dboslee dboslee added the no-changelog Indicates that a PR does not require a changelog entry label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

🤖 Vercel preview here: https://docs-68perfkob-goteleport.vercel.app/docs/ver/preview

@russjones
Copy link
Contributor

@dboslee Is this PR ready for re-review?

@dboslee dboslee requested a review from zmb3 February 16, 2024 21:14
@dboslee
Copy link
Contributor Author

dboslee commented Feb 16, 2024

@dboslee Is this PR ready for re-review?

yep

docs/pages/reference/backends.mdx Outdated Show resolved Hide resolved
docs/pages/reference/backends.mdx Outdated Show resolved Hide resolved
Copy link

🤖 Vercel preview here: https://docs-7002fbyz1-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-eaaiyc1x2-goteleport.vercel.app/docs/ver/preview

@dboslee
Copy link
Contributor Author

dboslee commented Feb 23, 2024

@zmb3 could you giving this a second look when you get a chance?

Copy link

🤖 Vercel preview here: https://docs-76y97k63g-goteleport.vercel.app/docs/ver/preview

docs/pages/reference/backends.mdx Outdated Show resolved Hide resolved
type="warning"
title="IMPORTANT"
>
CockroachDB can currently only be used to store Teleport's cluster state.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to feel like we should have a matrix on this page that lists each backend and each use case (cluster state, audit log, session recordings, etc) to indicate which backends support which types of data.

`storage` section of `teleport.yaml` as shown below.
- Deploy several Auth Service instances connected to the CockroachDB storage backend.
- Deploy several Proxy Service instances.
- Make sure that the Proxy Service instances and all Teleport agent services that
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't specific to CockroachDB in any way, is it?

docs/pages/reference/backends.mdx Outdated Show resolved Hide resolved
# parameters may be specified using the URL. For a detailed list of available
# parameters see https://www.cockroachlabs.com/docs/stable/connection-parameter
#
# If your certificates are not stored at the default ~/.postgresql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that we require mTLS? (Do we?)

Copy link

🤖 Vercel preview here: https://docs-aa2q8uwzb-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-dnooauwag-goteleport.vercel.app/docs/ver/preview

Merged via the queue into master with commit 13ceef6 Mar 10, 2024
36 of 37 checks passed
@klizhentas klizhentas deleted the david/crdb-docs branch March 10, 2024 19:09
@public-teleport-github-review-bot

@dboslee See the table below for backport results.

Branch Result
branch/v15 Failed

klizhentas added a commit that referenced this pull request Mar 10, 2024
* docs: cockroachdb storage backend configuration

* fix missing code block end quotes

* Update docs/pages/reference/backends.mdx

Co-authored-by: Zac Bergquist <[email protected]>

* Update crdb deploy and config references

* Update docs/pages/reference/backends.mdx

Co-authored-by: Paul Gottschling <[email protected]>

* Update docs/pages/reference/backends.mdx

Co-authored-by: Paul Gottschling <[email protected]>

* Update docs/pages/reference/backends.mdx

Co-authored-by: Paul Gottschling <[email protected]>

* Fix auth server lint

* Fix spellcheck lint

* Update docs/pages/reference/backends.mdx

Co-authored-by: Zac Bergquist <[email protected]>

* Update docs/pages/reference/backends.mdx

Co-authored-by: Zac Bergquist <[email protected]>

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Paul Gottschling <[email protected]>
Co-authored-by: Alexander Klizhentas <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 10, 2024
* docs: cockroachdb storage backend configuration

* fix missing code block end quotes

* Update docs/pages/reference/backends.mdx



* Update crdb deploy and config references

* Update docs/pages/reference/backends.mdx



* Update docs/pages/reference/backends.mdx



* Update docs/pages/reference/backends.mdx



* Fix auth server lint

* Fix spellcheck lint

* Update docs/pages/reference/backends.mdx



* Update docs/pages/reference/backends.mdx



---------

Co-authored-by: David Boslee <[email protected]>
Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Paul Gottschling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants