Connect My Computer: Agent compatibility fixes #32477
Conversation
|
Nit: Have we tried an opaque version of these where the internal background of the item is opaque white? (The corner poking through is grating on my soul.) |
|
@ibeckermayer I agree that it is not beautiful, but AFAIK we can't make the internal icon background opaque without modifying the svg (and that would break cases where we don't need the background). |
|
|
||
| if (!isAgentConfigured) { | ||
| if (!isAgentConfigured || isAgentCompatibilityUnkown) { |
There was a problem hiding this comment.
What's the reason behind the check for agent compatibility here?
There was a problem hiding this comment.
Ah right, we don't need it.
BTW, I realized that this condition !isAgentConfigured causes the indicator to be not shown during the setup.
I assume this is expected? I'm asking because I remember that I used your patch for this.
There was a problem hiding this comment.
I made a draft PR with a reply to this comment. #32638
I also added one improvement there to flip autoStart to false if the auto start fails.
Let me know what you think and I'll merge it to this branch.
# Conflicts: # web/packages/teleterm/src/ui/Documents/DocumentsRenderer.tsx
* Allow agent compatibility state to be 'unknown' * Show warning icon instead of read dot as the status indicator * Add a comment * Remove unnecessary check for agent compatibility * Avoid creating portal if topBarContainerRef is not present * Check compatibility when autostarting, not before autostart * Flip autoStart to false on failed autostart * Don't show Alert from CompatibilityError if current action has failed * Run prettier --------- Co-authored-by: Rafał Cieślak <[email protected]> (cherry picked from commit cc8fb14)
* Allow agent compatibility state to be 'unknown' * Show warning icon instead of read dot as the status indicator * Add a comment * Remove unnecessary check for agent compatibility * Avoid creating portal if topBarContainerRef is not present * Check compatibility when autostarting, not before autostart * Flip autoStart to false on failed autostart * Don't show Alert from CompatibilityError if current action has failed * Run prettier --------- Co-authored-by: Rafał Cieślak <[email protected]> (cherry picked from commit cc8fb14)
As Rafał noticed, the proxy version is not immediately available, and during that period we erroneously show an error about incompatible agent.
This PR adds changes
isAgentCompatibleboolean toagentCompatibilityunion with three values:unknown,compatibleandincompatible. The error should be shown only if the value isincompatible.Additionally, I changed the red dot in the status indicator to a warning icon to make readable for users with red-green confusion.
