Connect My Computer: Move icon to the top bar #31751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the icon was being unmounted when the status was changing to ''. It was making the animation to be start from the beginning multiple times, which did not look good.
gzdunek
force-pushed
the
gzdunek/move-cmc-icon-to-top
branch
from
b93b3d9 to
81d5e9a
Compare
zmb3
approved these changes
Sep 12, 2023
avatus
approved these changes
Sep 12, 2023
|
I think it looks really cool up in the top bar |
public-teleport-github-review-bot
bot
removed request for
ravicious and
ibeckermayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #27881
A decision was made to move the icon from the cluster view to the top bar to make the feature more visible to the users.
Why do we need React portal for this?
Because the icon needs
ConnectMyComputerContextwhich is not available at the top bar level.ConnectMyComputerContextwas designed to be used at the workspace level (so we have a separate context for each workspace).We could refactor the
ConnectMyComputerContextto be used at the app level, but that would have some downsides:killAgent(); after the changes it would becomekillAgent(rootClusterUri).The way we have chosen is to inject the icon from the workspace level into the top bar.
I also increased the min window width because of the space for an additional icon (btw we should do it even earlier to at least ~440px, because you can see a horizontal scrollbar and the top bar goes outside the window).