Connect My Computer: Generate the config file #29010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not review it yet, I misunderstood the point of |
gzdunek
force-pushed
the
gzdunek/cmc-agent-config-file
branch
from
5140e39 to
fa24094
Compare
|
Ready for review. |
ravicious
reviewed
Jul 17, 2023
gzdunek
force-pushed
the
gzdunek/cmc-agent-config-file
branch
from
fa24094 to
fefda87
Compare
ravicious
reviewed
Jul 19, 2023
ravicious
force-pushed
the
ravicious/cmc-roles-frontend
branch
from
f95729c to
e3f1c9f
Compare
Base automatically changed from
ravicious/cmc-roles-frontend
to
ravicious/cmc-roles
July 20, 2023 10:26
… `TokenProvisioner`
gzdunek
force-pushed
the
gzdunek/cmc-agent-config-file
branch
from
fefda87 to
5587ce2
Compare
# Conflicts: # lib/teleterm/daemon/daemon.go
ryanclark
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #27881
This PR adds generating the agent config file. To do this, we first have to create the join token for a node (this is done via
CreateConnectMyComputerNodeToken). Created token is then passed (with a few other params) tocreateAgentConfigFilefunction that creates the spawnsteleport configureprocess.RFD section https://github.com/gravitational/teleport/blob/master/rfd/0133-connect-my-computer.md#generating-the-config-file
I didn't run token removal (although I added a gRPC handler for it). I left a TODO for myself to do this along with joining the cluster.