fix(asciitable): Default maxCellLength to 0 if negative #16673
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run
tsh db ls
will panic in a small terminal session (in my case, 73 cols wide, in a split tmux-session):Teleport version ran on macOS:
This is probably not a perfect fix, but it resolves the panic. I'm sure people won't get much useful information from this if working in such a small terminal, but at least it won't completely crash
tsh
.This should fix #13130 (depending on the "perfectness" required) (sorry, I saw it was already assigned, but nothing has happened for a while, and I had already had a stab at it myself).
I wasn't completely sure if this was the best solution for this problem, so feel free to give pointers on other solutions/problems.