-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Update `[email protected]` * Remove `legacy` option * Add patch for `electron-builder` that allows universal builds to work * Remove packages patching * `[email protected]`
- Loading branch information
Showing
4 changed files
with
256 additions
and
250 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -214,17 +214,4 @@ module.exports = { | |
buildResources: 'build_resources', | ||
output: 'build/release', | ||
}, | ||
// TODO(gzdunek): Remove once @electron/rebuild migrates to node-gyp@10. | ||
// https://github.com/electron/rebuild/blob/main/package.json#L50 | ||
// (and remove the node-gyp resolution from the main package.json). | ||
// The `legacy` option makes the builder use an app-builder binary as in previous | ||
// versions of electron-builder. Without this option, it uses @electron/rebuild. | ||
// | ||
// We have to use node-gyp@10 because the macOS builder uses [email protected] | ||
// which is not compatible with node-gyp@9 (and we don't install distutils | ||
// separately there) | ||
// https://github.com/nodejs/node-gyp/issues/2869#issuecomment-1769572922. | ||
// I tried to use @electron/rebuild with node-gyp@10, but it didn't work, | ||
// rebuilding native deps simply hung forever. | ||
nativeRebuilder: 'legacy', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.