Skip to content

Commit

Permalink
Fix Connect for Intel Macs (#44383)
Browse files Browse the repository at this point in the history
* Update `[email protected]`

* Remove `legacy` option

* Add patch for `electron-builder` that allows universal builds to work

* Remove packages patching

* `[email protected]`
  • Loading branch information
gzdunek authored Jul 19, 2024
1 parent 58d431d commit f797b86
Show file tree
Hide file tree
Showing 4 changed files with 256 additions and 250 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"private": true,
"resolutions": {
"esbuild": "^0.20.2",
"node-gyp": "^10.0.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"**/d3-color": "^3.1.0",
Expand Down
13 changes: 0 additions & 13 deletions web/packages/teleterm/electron-builder-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,17 +214,4 @@ module.exports = {
buildResources: 'build_resources',
output: 'build/release',
},
// TODO(gzdunek): Remove once @electron/rebuild migrates to node-gyp@10.
// https://github.com/electron/rebuild/blob/main/package.json#L50
// (and remove the node-gyp resolution from the main package.json).
// The `legacy` option makes the builder use an app-builder binary as in previous
// versions of electron-builder. Without this option, it uses @electron/rebuild.
//
// We have to use node-gyp@10 because the macOS builder uses [email protected]
// which is not compatible with node-gyp@9 (and we don't install distutils
// separately there)
// https://github.com/nodejs/node-gyp/issues/2869#issuecomment-1769572922.
// I tried to use @electron/rebuild with node-gyp@10, but it didn't work,
// rebuilding native deps simply hung forever.
nativeRebuilder: 'legacy',
};
2 changes: 1 addition & 1 deletion web/packages/teleterm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@types/tar-fs": "^2.0.4",
"@types/whatwg-url": "^11.0.5",
"electron": "31.1.0",
"electron-builder": "^25.0.0-alpha.11",
"electron-builder": "^25.0.1",
"electron-notarize": "^1.2.2",
"electron-vite": "^2.3.0",
"events": "3.3.0",
Expand Down
Loading

0 comments on commit f797b86

Please sign in to comment.