Skip to content

Commit

Permalink
rfd updates (#50535)
Browse files Browse the repository at this point in the history
  • Loading branch information
stevenGravy authored Dec 23, 2024
1 parent 2d6ed26 commit d99a7a1
Show file tree
Hide file tree
Showing 12 changed files with 11 additions and 19 deletions.
2 changes: 1 addition & 1 deletion rfd/0016-dynamic-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ ensure backward compatibility with the already established workflows.
#### Choice 2.A

In this option, dynamic-configuration resources are understood to exist only
if they have been comitted as a result of having been specified in static
if they have been committed as a result of having been specified in static
configuration or via `tctl create`.

3. The command `tctl get cap` would therefore return an error saying
Expand Down
2 changes: 1 addition & 1 deletion rfd/0047-drop-vendor.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ which is difficult to maintain in a cross-platform way, and has broken
[gopls integration](https://github.com/gravitational/teleport/blob/30effc1f08b6a699772ff22f79ebe756fe1a1e34/Makefile#L942-L952)
a common tool used in Go development environments.

Lastly, there is no guarantee that the code comitted to vendor actually
Lastly, there is no guarantee that the code committed to vendor actually
reflects the contents of go.mod. The onus is on the developer to remember to run
`make update-vendor` and commit the results after making changes to
dependencies. This has created several cases of confusing build results amongst
Expand Down
2 changes: 1 addition & 1 deletion rfd/0055-webui-ss-paginate-filter.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ This technique does not support sorting, but provides faster performance and is

The web UI will not request for the entire list of resources upfront, but will provide a user with a `fetch more` button if a user desires to see the next page if any.

We can branch off into two functions with current `ListResources` based on if sorting was requested (orting will be disabled for `tsh`, so that `tsh` performance will not be affected):
We can branch off into two functions with current `ListResources` based on if sorting was requested (sorting will be disabled for `tsh`, so that `tsh` performance will not be affected):

- `listResources` (keeps current behavior)
- `listResourcesWithSort`
Expand Down
2 changes: 1 addition & 1 deletion rfd/0067-desktop-access-file-system-sharing.md
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ requested by RDP.

For files, `last_modified` is the last modified time of the file as specified by the [`mtime`](https://www.makeuseof.com/linux-file-timestamps/), in milliseconds
since the [UNIX epoch](https://en.wikipedia.org/wiki/Unix_time). For directories, `last_modified` should also be set to the
[directory's `mtime`](https://stackoverflow.com/a/3620704/6277051) when suchinformation is available. If such information is unavailable for a directory, such as
[directory's `mtime`](https://stackoverflow.com/a/3620704/6277051) when such information is available. If such information is unavailable for a directory, such as
in a browser environment, this value should be assigned the UNIX epoch itself (0).

For files, `size` is the size of the file in bytes. For directories, `size` is not the total size of the contents of the
Expand Down
2 changes: 1 addition & 1 deletion rfd/0073-discover.md
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ auto-discovery by going through the following flow:
3. The selected agent will perform initial discovery according to the provided
filters. This can be implemented by providing an API for the web UI to create
a "discovery request" which agents will watch.
4. The agent will attempt to fullfill the discovery request and will report
4. The agent will attempt to fulfill the discovery request and will report
errors, e.g. insufficient IAM policy, to the user. This can be implemented by
filling out a Status field on the agent's resource spec.
5. If successful, the UI wizard will display all resources matching the
Expand Down
2 changes: 1 addition & 1 deletion rfd/0083-machine-id-host-certs.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ Are you sure you want to continue connecting (yes/no/[fingerprint])?
This is nearly identical to the usual ssh TOFU message, save for the
easy-to-miss "Certificate invalid: expired" message. Users are likely
conditioned to accept this, and if that happens the expired or invalid host key
will be comitted to their `known_hosts` permanently, after which the "expired"
will be committed to their `known_hosts` permanently, after which the "expired"
message will not be shown again.

We'll need to document this caveat along with a workaround (e.g. a
Expand Down
2 changes: 1 addition & 1 deletion rfd/0084-license-expiration-warnings.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ state: implemented
## Required approvers

- Engineering: `@r0mant`
- Product: `@klizentas && @xinding33`
- Product: `@klizhentas && @xinding33`
- Security: `@reedloden`

## What
Expand Down
2 changes: 1 addition & 1 deletion rfd/0089-merge-webapps.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ build systems to successfully build Teleport.
- [ ] Remove `/webassets` submodule
- This submodule is no longer required as the web UI will be built on-demand.
- The folder will remain as the output location of the on-demand build but
will not be comitted.
will not be committed.
- [ ] Clone the [Webapps repository](https://github.com/gravitational/webapps) into
the Teleport root. [Maintaining their respective git histories](https://stackoverflow.com/questions/13040958/merge-two-git-repositories-without-breaking-file-history)
- [ ] This will need to be done for every respective version branch (v9, v10, v11)
Expand Down
2 changes: 1 addition & 1 deletion rfd/0122-moderated-file-transfers.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ OnApprove:
3. We can then use a policy checker to see if the approvers fulfill any moderation policy on the original requester. We can treat this check the same as the `checkIfStart` conditional for opening a session. If this comes back true, we notify the original requester with an event containing the ID of the `FileTransferRequest`

Once the client receives this final "approved" message, we can automatically send a "normal" SFTP request (over HTTP) with two new optional params, `sessionID` and `commandRequestId` (similar to the new optional `webauthn` param in this same request). The benefits of using the normal SFTP request is that we can conditionally choose to skip this entire approval process flow for non-moderated sessions.
If the session is not moderated, just send the SFTP request as usual. If it is, do the song and dance perscribed above.
If the session is not moderated, just send the SFTP request as usual. If it is, do the song and dance prescribed above.

### Updated file transfer api handler

Expand Down
2 changes: 1 addition & 1 deletion rfd/0133-connect-my-computer.md
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ agent. This follows from the behavior described in the “Downloading the agent
#### Log rotation
The MVP is not going to perform any extra log rotation beyond what the Teleport agent offerts out of
The MVP is not going to perform any extra log rotation beyond what the Teleport agent offers out of
the box which is creating a new log file every 24 hours. The logs are thus stored in the same
directory as the data directory of the agent and are removed together with the agent.
Expand Down
2 changes: 1 addition & 1 deletion rfd/0143-external-k8s-joining.md
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ traced back to a specific Kubernetes pod.

## Alternatives

### Introducing a seperate `kubernetes_remote` join method
### Introducing a separate `kubernetes_remote` join method

One alternative implementation was to introduce a new `kubernetes_remote` join
method that would use a bi-di gRPC RPC to create a challenge and response flow
Expand Down
8 changes: 0 additions & 8 deletions rfd/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@
"cmpopts",
"cockroachdb",
"codingllama",
"comitted",
"committerdate",
"commonfolk",
"compat",
Expand Down Expand Up @@ -395,7 +394,6 @@
"fspmarshall",
"ftruncate",
"fullchain",
"fullfill",
"fxamacker",
"gcpxyz",
"germaine",
Expand Down Expand Up @@ -465,7 +463,6 @@
"keypresses",
"keyv",
"kimlisa",
"klizentas",
"klizhentas",
"kubeconfig",
"kubeconfigs",
Expand Down Expand Up @@ -554,7 +551,6 @@
"objc",
"octocats",
"offboarding",
"offerts",
"olekukonko",
"omitempty",
"oncall",
Expand All @@ -568,7 +564,6 @@
"opentelemetry",
"oqzt",
"orapki",
"orting",
"osascript",
"otel",
"otelaws",
Expand All @@ -583,7 +578,6 @@
"partman",
"passwordless",
"pchar",
"perscribed",
"pgbouncer",
"pgconn",
"pgoutput",
Expand Down Expand Up @@ -677,7 +671,6 @@
"selfsubjectaccessreviews",
"selfsubjectrulesreviews",
"sendmsg",
"seperate",
"serviceaccount",
"serviceaccounts",
"servicecfg",
Expand Down Expand Up @@ -734,7 +727,6 @@
"subselection",
"subselects",
"subtests",
"suchinformation",
"sudoer",
"sudoersfile",
"supercede",
Expand Down

0 comments on commit d99a7a1

Please sign in to comment.