Skip to content

Commit

Permalink
Remove rate limiting on webapi/ping and webapi/connectionupgrade
Browse files Browse the repository at this point in the history
The limits on these endpoints can cause issues with legitimate use
cases trying to establish large numbers of connections from a single
host(i.e. Ansible Tower). Extending the limits would likely result
in a bar that constantly needs to be raised as clusters with this
workflow become larger. Instead the limits were removed entirely.
  • Loading branch information
rosstimothy committed Jun 11, 2024
1 parent e33de20 commit c875939
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/web/apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ func (h *Handler) bindDefaultEndpoints() {
// endpoint returns the default authentication method and configuration that
// the server supports. the /webapi/ping/:connector endpoint can be used to
// query the authentication configuration for a specific connector.
h.GET("/webapi/ping", h.WithUnauthenticatedHighLimiter(h.ping))
h.GET("/webapi/ping", httplib.MakeHandler(h.ping))
h.GET("/webapi/ping/:connector", h.WithUnauthenticatedHighLimiter(h.pingWithConnector))

// Unauthenticated access to JWT public keys.
Expand Down Expand Up @@ -920,7 +920,7 @@ func (h *Handler) bindDefaultEndpoints() {
h.DELETE("/webapi/sites/:site/discoveryconfig/:name", h.WithClusterAuth(h.discoveryconfigDelete))

// Connection upgrades.
h.GET("/webapi/connectionupgrade", h.WithHighLimiter(h.connectionUpgrade))
h.GET("/webapi/connectionupgrade", httplib.MakeHandler(h.connectionUpgrade))

// create user events.
h.POST("/webapi/precapture", h.WithUnauthenticatedLimiter(h.createPreUserEventHandle))
Expand Down

0 comments on commit c875939

Please sign in to comment.