Skip to content

Commit

Permalink
Discover Wizard: drop v13 edge case for Kube Access (#47790)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcoandredinis authored Oct 22, 2024
1 parent 9191081 commit 985c8a9
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -365,14 +365,6 @@ export function generateCmd(data: GenerateCmdProps) {
// AutomaticUpgradesTargetVersion contains a v, eg, v13.4.2.
// However, helm chart expects no 'v', eg, 13.4.2.
deployVersion = data.automaticUpgradesTargetVersion.replace(/^v/, '');

// TODO(marco): remove when stable/cloud moves to v14
// For v13 releases of the helm chart, we must remove the App role.
// We get the following error otherwise:
// Error: INSTALLATION FAILED: execution error at (teleport-kube-agent/templates/statefulset.yaml:26:28): at least one of 'apps' and 'appResources' is required in chart values when app role is enabled, see README
if (deployVersion.startsWith('13.')) {
roles = ['Kube'];
}
}

const yamlRoles = roles.join(',').toLowerCase();
Expand Down

0 comments on commit 985c8a9

Please sign in to comment.