Skip to content

Commit

Permalink
fix: Bypass OS compat workflow until GLIBC is fixed (#43810) (#43826)
Browse files Browse the repository at this point in the history
  • Loading branch information
codingllama authored Jul 3, 2024
1 parent d796d39 commit 9659a30
Showing 1 changed file with 35 additions and 29 deletions.
64 changes: 35 additions & 29 deletions .github/workflows/os-compatibility-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,24 @@ jobs:
WEBASSETS_SKIP_BUILD: 1

steps:
- name: Checkout Teleport
uses: actions/checkout@v3 # Cannot upgrade to v4 while this runs in centos:7 due to nodejs GLIBC incompatibility
- name: Bypass
run: echo 'Bypassed until the nodejs 20 GLIBC issue is fixed'

- name: Prepare workspace
uses: ./.github/actions/prepare-workspace

- name: Run make
run: |
make -j"$(nproc)" binaries FIDO2=static
- name: Upload binaries
uses: actions/upload-artifact@v3
with:
name: build
path: ${{ github.workspace }}/build/
# - name: Checkout Teleport
# uses: actions/checkout@v3 # Cannot upgrade to v4 while this runs in centos:7 due to nodejs GLIBC incompatibility
#
# - name: Prepare workspace
# uses: ./.github/actions/prepare-workspace
#
# - name: Run make
# run: |
# make -j"$(nproc)" binaries FIDO2=static
#
# - name: Upload binaries
# uses: actions/upload-artifact@v3
# with:
# name: build
# path: ${{ github.workspace }}/build/

test-compat:
needs: build
Expand All @@ -55,19 +58,22 @@ jobs:
contents: read

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Download binaries
uses: actions/download-artifact@v3
with:
name: build
path: ${{ github.workspace }}/build

- name: chmod +x
run: chmod +x ${GITHUB_WORKSPACE}/build/*
- name: Bypass
run: echo 'Bypassed until the nodejs 20 GLIBC issue is fixed'

- name: Run compat matrix
timeout-minutes: 10
run: |
cd ${GITHUB_WORKSPACE} && ./build.assets/build-test-compat.sh
# - name: Checkout
# uses: actions/checkout@v4
#
# - name: Download binaries
# uses: actions/download-artifact@v3
# with:
# name: build
# path: ${{ github.workspace }}/build
#
# - name: chmod +x
# run: chmod +x ${GITHUB_WORKSPACE}/build/*
#
# - name: Run compat matrix
# timeout-minutes: 10
# run: |
# cd ${GITHUB_WORKSPACE} && ./build.assets/build-test-compat.sh

0 comments on commit 9659a30

Please sign in to comment.