Feed the correct next page token to ListAllAccessListsMembers (#41045)

This PR fixes a typo when listing all members across all Access Lists
because when the number of members is bigger than the default page size
(1000), `nextToken` is not empty but we always pass the an empty value
to the `ListResources` call. This results in the callers to constantly
call `ListAllAccessListMembers` until they run out of memory.

Signed-off-by: Tiago Silva <[email protected]>

lib/services/simple/access_list.go

@@ -185,7 +185,7 @@ func (a *AccessListService) DeleteAllAccessListReviews(ctx context.Context) erro
 }
 
 // ListAllAccessListMembers returns a paginated list of all access list members for all access lists.
-func (a *AccessListService) ListAllAccessListMembers(ctx context.Context, pageSize int, pageToken string) (members []*accesslist.AccessListMember, nextToken string, err error) {
-	members, nextToken, err = a.memberService.ListResources(ctx, pageSize, nextToken)
+func (a *AccessListService) ListAllAccessListMembers(ctx context.Context, pageSize int, pageToken string) ([]*accesslist.AccessListMember, string, error) {
+	members, nextToken, err := a.memberService.ListResources(ctx, pageSize, pageToken)
 	return members, nextToken, trace.Wrap(err)
 }