Skip to content

Commit

Permalink
add todo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
flyinghermit committed Oct 28, 2024
1 parent 0f63d6a commit 45473e3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/auth/auth_with_roles.go
Original file line number Diff line number Diff line change
Expand Up @@ -1264,6 +1264,9 @@ func (c *resourceAccess) checkAccess(resource types.ResourceWithLabels, filter s
}

// KindSAMLIdPServiceProvider does not support label matcher
// TODO(sshah): remove this exclusion once we introduce role v8 and ability
// to enforce label matcher only for roles v8.
// https://github.com/gravitational/teleport/pull/47912
if resourceKind == types.KindSAMLIdPServiceProvider {
return true, nil
}
Expand Down

0 comments on commit 45473e3

Please sign in to comment.