Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amplify-preview go version #298

Merged
merged 53 commits into from
Dec 11, 2024

Conversation

taraspos
Copy link
Contributor

No description provided.

fheinecke and others added 30 commits November 4, 2024 14:39
env-loader: Allow for providing environments directory via arg
Docs PRs are consistently delayed due to the the fact that we currently
require two approvals to come from a small team of people who are all
very busy.

To mitigate this, we will treat PRs that touch docs similarly to PRs
that touch code. The new behavior is:

1. PRs continue to require two approvals, whether they touch code, docs,
   or both.
2. At least one of these two approvals must come from a code "owner"
   (otherwise known as a "group 1 reviewer"). This becomes the case
   whether the PR touches docs or not.
3. If the PR does not touch docs, then approvals from the docs reviewers
   don't count towards the 2 approval limit.
4. If the PR does touch docs, then the docs reviewers are added to group
   2 reviewers. Their reviews count towards the two review limit, but
   their reviews are not required in order to merge the PR.
@taraspos taraspos changed the base branch from main to taras/amplify-preview-job December 10, 2024 19:14
@taraspos taraspos force-pushed the taras/amplify-preview-go branch from 25accc1 to f2a6fa3 Compare December 11, 2024 12:46
@taraspos taraspos force-pushed the taras/amplify-preview-go branch from 7016d44 to b6d379b Compare December 11, 2024 12:59
@taraspos taraspos merged commit 5e63c93 into taras/amplify-preview-job Dec 11, 2024
4 checks passed
@taraspos taraspos changed the title Taras/amplify preview go amplify-preview go version Dec 18, 2024
@taraspos taraspos deleted the taras/amplify-preview-go branch December 18, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants