bot: Fix cloud reviewer assignments #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with cloud repo assignments, remove the Team field, and add a
preferredOnly
flag.Context: our reviewer data model was changed last month to allow core team members to review code in the cloud repository. The new team maps (CoreReviewers and CloudReviewers) can include both core and cloud engineers.
Background:
This PR aligns the reviewer code with the
reviewers.json
data model. The data model has a number of related entities: teams, repositories, reviewers, and paths. Ideally, the top-level reviewer groups would be the repository since a preferredReviewerPath's context is a specific repository. Our data model adds a bit of ambiguity by defining teams (core or cloud), where the cloud team manages the cloud repository and the core team manages the teleport and teleport.e repositories. This change does not address the repository ambiguity but does allow for a single reviewer to be defined in both cloud and core teams.