Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert slices package from stdlib #210

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: Revert slices package from stdlib #210

merged 2 commits into from
Jan 5, 2024

Conversation

jimbishopp
Copy link
Contributor

Many of the downstream actions that use this bot don't execute using the most recent Go version. Downgrade the slices package to use golang.org/x/exp/slices rather than the stdlib version only available in 1.21.5.

@jimbishopp jimbishopp requested review from a team and zmb3 January 5, 2024 21:23
@jimbishopp jimbishopp changed the title fix: Revert slices package to non-stdlib fix: Revert slices package from stdlib Jan 5, 2024
bot/internal/bot/bot.go Outdated Show resolved Hide resolved
bot/internal/review/review_test.go Outdated Show resolved Hide resolved
@jimbishopp jimbishopp merged commit cc43ad4 into main Jan 5, 2024
8 checks passed
@jimbishopp jimbishopp deleted the jim/fix branch January 8, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants