bot: Allow the same reviewer in both core and cloud repos

[jimbishopp]

This PR addresses the "Cross-Repo Reviewers" issue described in #205.

The current bot configuration data model doesn't allow an engineer to be a reviewer in both the cloud and core repositories. This is an issue because we now require the core team to submit PRs to the cloud repo to manage either tools they own (e.g. release server) or deploy a new version of a component they own (e.g. TAG).

This PR provides a hacky solution that will allow us to change the bot config data model to include a cloud and core team section, while keeping the original code reviewers map in the bot so we don't have to change a large amount of code.

[zmb3]

Can you include an example of what the new reviewers config will look like? I'm having a hard time telling exactly how this changes things.

[zmb3]

Suggested change

	func (e *Environment) Team() string {
	func (e *Environment) RepoOwner() string {

Perhaps?

[jimbishopp]

Changed to RepoOwnerTeam since it returns a Team name.

[jimbishopp]

Can you include an example of what the new reviewers config will look like? I'm having a hard time telling exactly how this changes things.

@zmb3 the test was updated to demonstrate what the new config will look like. Essentially codeReviewers will be replaced by coreReviewers and cloudReviewers. I also removed the Team attribute and set it when loading the file. I marked it as deprecated for now because it is baked into so much logic but it can be removed if we refactor the code to determine the team based on the environment/repo. I think eventually we'll need to have a data model that defines reviewers per repo but I didn't want to take that on right now.

UPDATE: opened a PR in the github-terraform repo with changes to the reviewers.json file.

shared-workflows/bot/internal/review/review_test.go

Lines 1196 to 1217 in d85387b

	const reviewers = `
	{
	"coreReviewers": {
	"1": {
	"team": "Core",
	"owner": true
	},
	"2": {
	"team": "Core",
	"owner": false
	}
	},
	"cloudReviewers": {
	"1": {
	"team": "Cloud",
	"owner": true
	},
	"2": {
	"team": "Cloud",
	"owner": false
	}
	},

[jimbishopp]

I added commit that removes the need to set the Team field in the reviewers.json configuration file. It is now set automatically when the file is loaded.