Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace tj-actions/changed-files with dorny/paths-filter" #193

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

wadells
Copy link
Contributor

@wadells wadells commented Dec 4, 2023

Reverts #189.

Callers need additional permissions (read: pull-request) or they'll fail with the following signature:

https://github.com/gravitational/cloud-terraform/actions/runs/7091297245/job/19300146222?pr=3784

Fetching list of changed files for PR#3784 from Github API
  Invoking listFiles(pull_number: 3784, per_page: 100)
Error: Resource not accessible by integration

Rolling back for now. I'll look at updating call sites and then rolling back forward.

This is because dorny/paths-filter uses the github api to read diffs instead of tj-actions using the git history of the local checkout. At least that is what my initial research suggests.

@wadells wadells requested review from a team December 4, 2023 19:17
@wadells wadells merged commit 685c1cc into main Dec 4, 2023
7 of 8 checks passed
@wadells wadells deleted the revert-189-walt/replace-tj-actions branch December 4, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants