Add verification of DB migrations for access-graph #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fheinecke
reviewed
Nov 28, 2023
bot/main.go
Outdated
Comment on lines
181
to
186
| var reviewer *review.Assignments | ||
| if flags.workflow == "assign" || flags.workflow == "check" { | ||
| reviewer, err = review.FromString(flags.reviewers) | ||
| if err != nil { | ||
| return nil, trace.Wrap(err) | ||
| } |
There was a problem hiding this comment.
I would be very careful about this. This value is used in several other places that are not immediately clear. I took a look into doing the exact same thing a couple of months ago and decided against it because it would break other workflows without much more refactoring.
jimbishopp
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding CI changes in
access-graph: #185 (WIP)access-graphreporeviewersparameter optional when not runningassignorcheckworkflows