Skip Dependency Review action in merge queue #180
Conversation
Various attempts to skip the action were tried in `teleport.e`, but they all resulted in the Dependency Review check never reporting a status. This blocked all PRs from landing until the merge queue was disabled. By defining the skip here instead of in an upstream repo it should prevent the aforementioned issue.
|
@reedloden I was curious how this was working for Unfortunately only one of the linked PRs has been merged. Should we require Dependency Review on |
|
Can we just add As far as merge queue goes, I suspect we need to do something like this: |
|
@reedloden @jentfoo is making the dependency check required in |
|
@reedloden @jentfoo Friendly ping |
|
@reedloden could you please weigh in? Is this ok to merge without addressing your concerns about the check still not being required in |
|
So, if we need to land this to unbreak something, we can, but this is not the correct fix. We need this action to run within the merge queue. I'd rather us re-enable dependency review everywhere and just explicitly allowlist those rust packages for now. |
|
@reedloden the problem is that the Dependency Review in its current form does not work in the merge queue, see https://gravitational.slack.com/archives/C0351AUPJ8K/p1699371871519019 for more details. This prevents us from enabling the merge queue in any repository that has the Dependency Review as a required check (currently only The intent of this PR is to bypass the Dependency Review in the merge queue until @jentfoo is able to address the issues that the check has when triggered by the merge queue. A PR from a repository with the Dependency Review as a required check can only enter the merge queue if the check already passed. A PR from a repository that doesn't have the Dependency Review as a required check will not trigger the check when it enters the merge queue. |
Various attempts to skip the action were tried in
teleport.e, but they all resulted in the Dependency Review check never reporting a status. This blocked all PRs from landing until the merge queue was disabled. By defining the skip here instead of in an upstream repo it should prevent the aforementioned issue.