Skip to content

Commit

Permalink
add logic to wait for job completion
Browse files Browse the repository at this point in the history
  • Loading branch information
taraspos committed Dec 16, 2024
1 parent 8790c1f commit f89122e
Show file tree
Hide file tree
Showing 5 changed files with 68 additions and 141 deletions.
138 changes: 0 additions & 138 deletions .github/actions/amplify-preview/action.yaml

This file was deleted.

4 changes: 4 additions & 0 deletions tools/amplify-preview/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ inputs:
github_token:
required: true
description: "Github token with permissions to read/write comments in pull request"
wait:
default: "false"
description: "If Amplify deployment is pending/running state wait for it's completion"
runs:
using: composite
steps:
Expand All @@ -30,6 +33,7 @@ runs:
GIT_BRANCH_NAME: ${{ steps.extract_branch.outputs.branch }}
CREATE_BRANCHES: ${{ inputs.create_branches }}
GITHUB_TOKEN: ${{ inputs.github_token }}
WAIT: ${{ inputs.wait }}
shell: bash
run: |
pushd ./tools/amplify-preview/; go run ./; popd
30 changes: 28 additions & 2 deletions tools/amplify-preview/amplify.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
Copyright 2024 Gravitational, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package main

import (
Expand All @@ -15,8 +31,13 @@ import (
)

var (
errBranchNotFound = errors.New("Branch not found")
errNoJobForBranch = errors.New("Current branch has no jobs")
errBranchNotFound = errors.New("Branch not found")
errNoJobForBranch = errors.New("Current branch has no jobs")
amplifyJobCompletedStatuses = map[types.JobStatus]struct{}{
types.JobStatusFailed: {},
types.JobStatusCancelled: {},
types.JobStatusSucceed: {},
}
)

const (
Expand Down Expand Up @@ -186,6 +207,11 @@ func appIDFromBranchARN(branchArn string) (string, error) {
return "", fmt.Errorf("Invalid branch ARN")
}

func isAmplifyJobCompleted(job *types.JobSummary) bool {
_, ok := amplifyJobCompletedStatuses[job.Status]
return ok
}

func (err aggregatedError) Error() error {
if len(err.perAppErr) == 0 {
return nil
Expand Down
16 changes: 16 additions & 0 deletions tools/amplify-preview/github.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
Copyright 2024 Gravitational, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package main

import (
Expand Down
21 changes: 20 additions & 1 deletion tools/amplify-preview/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"log/slog"
"os"
"strings"
"time"

"github.com/alecthomas/kingpin/v2"
"github.com/aws/aws-sdk-go-v2/aws"
Expand All @@ -38,6 +39,13 @@ var (
gitBranchName = kingpin.Flag("git-branch-name", "Git branch name").Envar("GIT_BRANCH_NAME").Required().String()
createBranches = kingpin.Flag("crate-branches",
"Defines whether Amplify branches should be created if missing, or just lookup existing ones").Envar("CREATE_BRANCHES").Default("false").Bool()
wait = kingpin.Flag("wait",
"Wait for pending/running job to complete").Envar("wait").Default("false").Bool()
)

const (
jobWaitSleepTime = 30 * time.Second
jobWaitTimeAttempts = 40
)

func main() {
Expand Down Expand Up @@ -96,6 +104,17 @@ func main() {
}
}

for i := 0; *wait && !isAmplifyJobCompleted(job) && i < jobWaitTimeAttempts; i++ {
job, err := amp.GetJob(ctx, branch, nil)
if err != nil {
logger.Error("failed to get amplify job", logKeyBranchName, *gitBranchName, "error", err)
os.Exit(1)
}

logger.Info("Job is not in a completed state yet. Sleeping...", logKeyBranchName, *gitBranchName, "job_status", job.Status, "job_id", job.JobId)
time.Sleep(jobWaitSleepTime)
}

if err := postPreviewURL(ctx, amplifyJobToMarkdown(job, branch)); err != nil {
logger.Error("failed to post preview URL", "error", err)
os.Exit(1)
Expand All @@ -104,7 +123,7 @@ func main() {
logger.Info("Successfully posted PR comment")

if job.Status == types.JobStatusFailed {
logger.Error("amplify job is in failed state", "job_status", job.Status, "job_id", job.JobId)
logger.Error("amplify job is in failed state", logKeyBranchName, *gitBranchName, "job_status", job.Status, "job_id", job.JobId)
os.Exit(1)
}
}

0 comments on commit f89122e

Please sign in to comment.