Respond to zmb3 feedback

- Fix spelling.
- Add log if admin reviewers are assigned.
- Deduplicate preferred reviewers.

bot/internal/review/review.go

@@ -210,6 +210,7 @@ func (r *Assignments) getDocsReviewers(e *env.Environment, files []github.PullRe
 
 	// If no docs reviewers were assigned, assign admin reviews.
 	if len(reviewers) == 0 {
+		log.Println("No docs reviewers found. Assigning admin reviewers.")
 		return r.getAdminReviewers(e.Author)
 	}
 	return reviewers
@@ -270,14 +271,26 @@ func (r *Assignments) getPreferredReviewers(set []string, files []github.PullReq
 
 // getAllPreferredReviewers returns a list of reviewers that would be
 // preferrable to review the provided changeset. Includes all preferred
-// reviewers for each file path in the chagne set.
+// reviewers for each file path in the changeset.
 func (r *Assignments) getAllPreferredReviewers(set []string, files []github.PullRequestFile) (preferredReviewers []string) {
+	// Check each key in the preferred reviewer map, which is a file path
+	// that reviewers are assigned to. For any file names in the changeset
+	// that begin with that file path, add the reviewers for that pile path
+	// to the set of preferred reviewers. Look up each reviewer in a map to
+	// avoid duplication.
+	assigned := make(map[string]struct{})
 	for path, reviewers := range r.getPreferredReviewersMap(set) {
 		for _, file := range files {
 			if !strings.HasPrefix(file.Name, path) {
 				continue
 			}
-			preferredReviewers = append(preferredReviewers, reviewers...)
+			for _, rev := range reviewers {
+				if _, ok := assigned[rev]; ok {
+					continue
+				}
+				assigned[rev] = struct{}{}
+				preferredReviewers = append(preferredReviewers, rev)
+			}
 		}
 	}
 	return preferredReviewers

bot/internal/review/review_test.go

@@ -504,6 +504,24 @@ func TestGetDocsReviewers(t *testing.T) {
 			},
 			reviewers: []string{"1", "2"},
 		},
+		{
+			desc: "preferred code reviewer for docs page with duplicate code reviewers",
+			assignments: &Assignments{
+				c: &Config{
+
+					CodeReviewers: map[string]Reviewer{
+						"2": {Team: "Core", Owner: true, PreferredReviewerFor: []string{"server-access", "database-access"}},
+						"3": {Team: "Core", Owner: true, PreferredReviewerFor: []string{"server-access", "database-access"}},
+					},
+				},
+			},
+			author: "4",
+			files: []github.PullRequestFile{
+				{Name: "server-access/get-started.mdx"},
+				{Name: "database-access/get-started.mdx"},
+			},
+			reviewers: []string{"2", "3"},
+		},
 	}
 	for _, test := range tests {
 		t.Run(test.desc, func(t *testing.T) {
@@ -1012,6 +1030,24 @@ func TestCheckInternal(t *testing.T) {
 			large:   false,
 			result:  true,
 		},
+		{
+			desc:       "docs-with-non-preferred-code-reviewer",
+			repository: "teleport",
+			author:     "1",
+			reviews: []github.Review{
+				{Author: "3", State: Approved},
+			},
+			files: []github.PullRequestFile{
+				{
+					Name: "docs/pages/server-access/get-started.mdx",
+				},
+			},
+			docs:    true,
+			code:    false,
+			release: false,
+			large:   false,
+			result:  false,
+		},
 	}
 	for _, test := range tests {
 		t.Run(test.desc, func(t *testing.T) {