Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable banner revalidation #433

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

TuukkaIkius
Copy link
Contributor

@TuukkaIkius TuukkaIkius commented Feb 8, 2024

Changes

  • Disabled event banner revalidation while we work on troubleshooting issues with excessive amounts of api requests

Other PRs:
Next https://github.com/gravitational/next/pull/2385
Blog https://github.com/gravitational/blog/pull/501

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 11:26am

avatus
avatus previously approved these changes Feb 9, 2024
Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: im a fan of removing code rather than commenting out. if you decide to leave the code in but commented, another comment with some information on why/links to an issue/PR would be better.

@TuukkaIkius TuukkaIkius merged commit 26c9593 into main Feb 22, 2024
9 checks passed
@TuukkaIkius TuukkaIkius deleted the TuukkaTahtinen/DisableBannerRevalidation branch February 22, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants