Update Navigation Design #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
avatus
previously approved these changes
Feb 1, 2024
avatus
previously approved these changes
Feb 5, 2024
|
@avatus Sorry for the re-request. Fixed a few things to get all CI/CD tests and checks to pass. All good now! |
ptgott
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES
Update Navigation design along the next and blog repos
Added box sizing and min width values to the docs layout body class to fix an issue with content overflowing on some viewports.
Skipped navigation data tests for now as those need to be updated to match the new setup, but we didn't have time to do that within this project's timeline
Preview
https://docs-git-tuukkatahtinen-navigationredesign-goteleport.vercel.app/docs/
Related Next repo PR: https://github.com/gravitational/next/pull/2344
Related Blog repo PR: https://github.com/gravitational/blog/pull/490