Support expandable images #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptgott this seems to fail to deploy on amplify:
|
Closes #26 Eject `MDXComponents/Img` using Docusaurus swizzling. Adapt the expandable image logic from the `Image` component in `gravitational/docs` to the Docusaurus site, copying the `ModalImage` and `PlainImage` components, plus their supporting hooks, into the ejected `MDXImg` component.
ptgott
force-pushed
the
paul.gottschling/26-click-expand
branch
from
2aebb56 to
17eca09
Compare
|
Preview details
|
|
@taraspos Thanks for catching the failure. The deployment seems to be working as expected now |
taraspos
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Eject
MDXComponentsusing Docusaurus swizzling. Adapt the expandable image logic from theImagecomponent ingravitational/docsto the Docusaurus site, copying theModalImageandPlainImagecomponents, plus their supporting hooks, into the ejectedMDXImgcomponent.