"Ready to verify"

[chadwhitacre]

← Limit pending verifications (#4579) — Support queueing w/o participants (#4548) →

---

Implement the "Ready to verify" idea from #4557 (comment).

Todo

• vary button and action based on verification state of selected email address
• update claim action so it happens immediately (w/ notification to self) → Don't require reverification for package claiming #4520
• update bulk claiming so it happens immediately (w/ notification to self) → Don't require reverification for package claiming #4520
• implement verify action → Don't require reverification for package claiming #4520
• rip out claim-by-email wiring entirely → Don't require reverification for package claiming #4520
• change base back to master post-Limit pending verifications in emails UI #4579

[chadwhitacre]

ae7ca59:

[chadwhitacre]

@rohitpaulk Putting this in review, punting the rest to #4520. With this we are minimally protected against phishing ... enough for now, methinks.

[chadwhitacre]

Rebased, was eb6b4a8.

[rohitpaulk]

Rebased

[chadwhitacre]

Rebased now that #4579 is in.

[chadwhitacre]

Erm, I lied. Conflicts!

[mattbk]

I didn't fix the conflicts yet, but the current version works on my end. If someone gets around to fixing the conflicts before I do, I can merge.

[mattbk]

Oops, I was being too inclusive there.

gratipay/testing/browser.py:17: redefinition of unused 'StaleElementReferenceException' from line 10
gratipay/testing/browser.py:18: redefinition of unused 'WebDriverWait' from line 14
gratipay/testing/browser.py:19: redefinition of unused 'staleness_of' from line 13

[mattbk]

Still checks out for me. Updating.

[mattbk]

Someone else can merge since I fixed the conflicts.

[chadwhitacre]

I'm trying to rebase on master and getting a weird result:

The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git reset'
rebase in progress; onto 5fbc18e
You are currently rebasing branch 'ready-to-verify' on '5fbc18e'.

nothing to commit, working directory clean
Could not apply afceb538d9dad5e5efaada1b8b185ed5e6d71969... Fix indentation

Possibly because some of these commits were already merged under #4579?

[chadwhitacre]

Yup, looks like it. 👍

[chadwhitacre]

Rebased! Was 8d1bfbe. I believe it's back to you for the merge, @mattbk? :-)